Changeset 237

Show
Ignore:
Timestamp:
06/02/2006 04:21:28 PM
Author:
luedi
Message:

If a file is modified after the parent project was moved, the converter reported, that there is no more active item path to commit.

The reason for this was, when a project is moved, the old parent is declared deleted and the a new parent is added to the project. The code did an implicit assumption, that a project only has one parent, which is active. The correct logic is that a project can only have one active parent.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • branches/Dirk/pin_handler/Vss2Svn/ActionHandler.pm

    r235 r237  
    409409 
    410410    # the move target is now also a valid "copy from" itempath 
    411 #    $self->_track_item_path ($physname, $row->{parentphys}, $version, $itempath); 
     411    $self->_track_item_path ($physname, $row->{parentphys}, $physinfo->{last_version}, $itempath); 
    412412 
    413413    return 1; 
     
    670670    $self->{physname_seen} .= "$physname, "; 
    671671 
    672     my @pathstoget = $self->_get_parents ($physname); 
    673  
    674     # TODO: there should only be one parent 
     672    # In a move szenario, we can have one deleted and one active parent. We 
     673    # are only interested in the active ones here. 
     674    my @pathstoget = $self->_get_active_parents ($physname); 
     675 
     676    # TODO: For projects there should be only one active parent 
    675677    my $parent = $pathstoget[0]; 
    676678     

These ads are automatically generated by Google based on the content of this page. Revenue from these ads helps to pay for hosting fees of this site; however, these ads do not constitute an endorsement by PumaCode.org.